Ticket #93 (closed defect: fixed)

Opened 7 months ago

Last modified 6 months ago

image JPG crashes shoes in Win32

Reported by: jesset77 Owned by:
Milestone: Raisins Keywords:
Cc:

Description

Problem does not occur with png or gif

Test case:

Shoes.app do

image "test.jpg"

end

"test.jpg" must be a real file for the testcase to function, but it need not be a real jpg. Even a blank file with that name works.

Change History

Changed 7 months ago by harold

I traced this through for a bit this morning, but now I'm out of time, and I haven't got a fix. Bummer!

It looks like that in shoes_surface_create_from_jpeg, fopen is returning something that looks valid (the pointer itself is not NULL) but the goods are actually not present (f->_ptr *is* NULL)

Why this is happening is eluding me. Le sigh.

Later... f looks to be set up as the read source (jpeg_stdio_src), and then when it actually goes to read (jpeg_read_header) crashing ensues.

:((

Changed 7 months ago by jesset77

I've actually observed that image "file.ext" where "ext" is ANYTHING save "gif" or "png" causes a crash; including jpg.

Do the gif/png functions perform different filehandling than jpg? Example, gif/png you pass the filename to the cairo function whereas "jpg" you read the file data first, or else pass the file handle to the cairo function?

Something must be different about the handling.

Changed 6 months ago by why

  • milestone set to Raisins

Set to be fixed before Raisins.

Changed 6 months ago by why

  • status changed from new to closed
  • resolution set to fixed

Okay, checked in a fix for this in [473]. Just reopen this if you're still seeing problems.

Note: See TracTickets for help on using tickets.