:title no longer does anything

[garretbuell]

Passing :title to Shoes.app no longer does anything. Check out book.rb It is no longer called "Incidents, a Book" it is now just simply "Shoes". How boring!

[harold]

[disclaimer - my advice applies to windows only]

The :title thing still works if you pass the .rb file in on the command line.

Example: shoes.exe .\samples\book.rb

It doesn't seem to work when starting an app from the file picker (after double-clicking shoes.exe) because shoes_app_title only seems to get called on the initial startup.

Someone more familiar with the up-starting of a shoes app would know how to fix it. I think I'll look at other issues instead.

[harold]

Nevermind, there don't seem to be any other issues that I know anything about.

After some research into how startup really works, I'm guessing that shoes_app_title really wants to be called in shoes_app_main instead of in shoes_app_open...

I'm making this guess because shoes_app_open seems to only get called once (upon initial startup) while shoes_app_main appears to get called both upon initial startup, and *again* when a shoes app is picked from the file picker. (when no command line args are present)...

The attached patch is tested on win32 only, but seems pretty safe to me. Unless there are some goofy restrictions on when you call SetWindowTitleWithCFString or gtk_window_set_title

Hope that helps,

-Harold

[harold]

Patch for fixing :title when picking the shoes app from the file picker (as opposed to passing it on the command line)