Changeset 161

Timestamp:

02/21/2008 13:41:55 (3 months ago)

Author:

why

Message:

• lib/hpricot/traverse.rb: slight fixes from wycats for get_elements_by_tag_name, from ticket #101.
  

Location:

trunk

Files:

• lib/hpricot/traverse.rb (modified) (1 diff)
• test/test_parser.rb (modified) (1 diff)

trunk/lib/hpricot/traverse.rb

@@ -524 +524 @@
     def get_elements_by_tag_name(*a)
       list = Elements[]
+      a.delete("*")
       traverse_element(*a.map { |tag| [tag, "{http://www.w3.org/1999/xhtml}#{tag}"] }.flatten) do |e|
-          list << e
+        list << e if e.elem?
       end
       list

trunk/test/test_parser.rb

@@ -47 +47 @@
     assert_equal 'link1', @basic.get_elements_by_tag_name('a')[0].get_attribute('id')
     assert_equal 'link1', @basic.get_elements_by_tag_name('body')[0].get_element_by_id('link1').get_attribute('id')
+  end
+  
+  def test_get_elements_by_tag_name_star
+    simple = Hpricot.parse("<div><p id='first'>First</p><p id='second'>Second</p></div>")
+    assert_equal 3, simple.get_elements_by_tag_name("*").size
+    assert_equal 1, simple.get_elements_by_tag_name("div").size
+    assert_equal 2, simple.get_elements_by_tag_name("p").size
   end