Changeset 154

Timestamp:

07/04/2007 17:36:01 (17 months ago)

Author:

why

Message:

• lib/hpricot/tag.rb: bug in quoting of attributes, found by mikel lindsaar.
  

Location:

trunk

Files:

• lib/hpricot/tag.rb (modified) (1 diff)
• test/test_builder.rb (modified) (1 diff)

trunk/lib/hpricot/tag.rb

@@ -101 +101 @@
         @raw_attributes.map do |aname, aval|
           " #{aname}" +
-            (aval ? "=\"#{aval}\"" : "")
+            (aval ? "=#{html_quote aval}" : "")
         end.join
       end

trunk/test/test_builder.rb

@@ -22 +22 @@
     assert_equal "\342\202\254\342\200\242", doc.at("text()").to_s
   end
+
+  def test_escaping_attrs
+    text = "<span style='font-family:\"MS Mincho\"'>Some text</span>"
+    assert_equal "<span style=\"font-family:\\\"MS Mincho\\\"\">Some text</span>",
+      Hpricot(text).to_html
+  end
 end