Problem on file uploads

[brmichel]

In some (bad) cases, uploading a file can failed. In Base#initialize near the line 400 of camping-unabridged.rb, the uploaded file is read by block of 16384 bytes:

          while l=@in.read(16384)
            if l=~b
              o<<$`.chomp
              @in.seek(-$'.size,IO::SEEK_CUR)
              break
            end
            o<<l
          end 

b is a regexp for detecting the boundary. But if the boundary is splitted on 2 blocks, the regexp doesn't match it.

I have this problem while uploading a file of 65516 bytes, with an HTML form data after it. The HTML form data doesn't appear in @input, but the temporary file created by camping contains the uploaded file and the HTML data.

[why]

Okay, good, you're right. Just needs a slight change in that loop to keep around the last line.

[zimbatm]

I don't know if the CGI lib supports file upload but I was thinking... why not use the ruby cgi lib so that we can remove a few more lines in Camping ?

[why]

Because all of this compact parsing and sorting is part of the Camping miracle. I also really dislike cgi.rb.

[brmichel]

My patch

[brmichel]

I have tested the attached patch, and it works.

[evanweaver]

Attaching vaguely altered patch with generalized paths, so that people can apply it directly to gems.

[evanweaver]

Generalized paths

[why]

Okay! Applied! Thanks friendly folks.