Changeset 225 for trunk/lib/camping/session.rb

Timestamp:

09/26/2007 03:52:10 (14 months ago)

Author:

zimbatm

Message:

Working on Sessions and database :

• FIX: Session table was always created
  
• FIX: Sessions weren't stored correctly because of the custom
  non-autoincrement id. Using SQL injection to bypass the forced "id" :-]
  (aka. where opinionated software is not always good)
  
• ENHANCEMENT: Added index for sessions's hashid for faster lookup
  
• FIX: 'sqlite3_api' was loaded after the connection.
  

Files:

• trunk/lib/camping/session.rb (modified) (6 diffs)

trunk/lib/camping/session.rb

@@ -12 +12 @@
 # For a basic tutorial, see the *Getting Started* section of the Camping::Session module.
 require 'camping'
+require 'camping/db'
 
 module Camping::Models
@@ -18 +19 @@
 class Session < Base
     serialize :ivars
+    # SQL injection to bypass id field checks
+    set_primary_key '"="" OR "'
+
     def []=(k, v) # :nodoc:
         self.ivars[k] = v
@@ -39 +43 @@
     # If none is found, generates a new session.
     def self.persist cookies
+        session = nil
         if cookies.camping_sid
             session = Camping::Models::Session.find_by_hashid cookies.camping_sid
@@ -64 +69 @@
             ActiveRecord::Schema.define do
                 create_table :sessions, :force => true, :id => false do |t|
-                    t.column :hashid,      :string,  :limit => 32
+                    t.column :hashid,      :string,  :limit => 32, :null => false
                     t.column :created_at,  :datetime
                     t.column :ivars,       :text
                 end
+                add_index :sessions, [:hashid], :unique => true
             end
             reset_column_information
@@ -109 +115 @@
         @state = (session[app] ||= Camping::H[])
         hash_before = Marshal.dump(@state).hash
-        s = super(*a)
+        return super(*a)
+    ensure
         if session
             hash_after = Marshal.dump(@state).hash
@@ -117 +124 @@
             end
         end
-        s
     end
 end